afedulov commented on code in PR #23553:
URL: https://github.com/apache/flink/pull/23553#discussion_r1370765358
##########
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java:
##########
@@ -1161,9 +1163,10 @@ void
testYieldingOperatorChainableToTaskNotChainedToLegacySource() {
*/
@Test
void testYieldingOperatorProperlyChainedOnLegacySources() {
+ // TODO: this test can be removed when the legacy SourceFunction API
gets removed
StreamExecutionEnvironment chainEnv =
StreamExecutionEnvironment.createLocalEnvironment(1);
- chainEnv.fromElements(1)
+ chainEnv.addSource(new LegacySource())
Review Comment:
Seems so. Has something to do with threading:
```
[FLINK-16219][runtime] Disallow chaining of legacy source and yielding
operator.
This change allows yielding operators to be eagerly chained whenever
possible, except after legacy sources.
Yielding operators do not properly work when processInput is called from
another thread, but are usually fine in any other chain.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
