afedulov commented on code in PR #23553:
URL: https://github.com/apache/flink/pull/23553#discussion_r1370841305
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/processor/MultipleInputNodeCreationProcessorTest.java:
##########
@@ -123,7 +124,8 @@ private void createChainableStream(TableTestUtil util) {
}
private void createNonChainableStream(TableTestUtil util) {
- DataStreamSource<Integer> dataStream =
util.getStreamEnv().fromElements(1, 2, 3);
+ DataStreamSource<Integer> dataStream =
+ util.getStreamEnv().fromCollection(Arrays.asList(1, 2, 3));
Review Comment:
The FLIP-27 source gets chained, while the test requires a non chainable
stream (compare with `createChainableStream`). In this PR I dealt with it by
switching to fromCollection that is still based on the `SourceFunction`. In the
follow-up PR for the `fromCollection` migration I had to add a legacy source:
https://github.com/apache/flink/pull/23558/files#diff-0e02bf442f990b526e7a5fe5203efccccf9e0d19924419b63d0bb0aa573f2b55R119
Not sure if we can get a `nonChainableStream` with a FLIP-27 source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
