zentol commented on code in PR #23553:
URL: https://github.com/apache/flink/pull/23553#discussion_r1371715012
##########
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java:
##########
@@ -1188,14 +1191,14 @@ void testChainingOfOperatorsWithDifferentMaxParallelism(
configuration.set(
PipelineOptions.OPERATOR_CHAINING_CHAIN_OPERATORS_WITH_DIFFERENT_MAX_PARALLELISM,
chainingOfOperatorsWithDifferentMaxParallelismEnabled);
- configuration.set(PipelineOptions.MAX_PARALLELISM, 10);
+ configuration.set(PipelineOptions.MAX_PARALLELISM, 1);
try (StreamExecutionEnvironment chainEnv =
StreamExecutionEnvironment.createLocalEnvironment(1,
configuration)) {
chainEnv.fromElements(1)
.map(x -> x)
// should automatically break chain here
.map(x -> x)
- .setMaxParallelism(1)
+ .setMaxParallelism(10)
Review Comment:
sounds good 👍
##########
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java:
##########
@@ -1188,14 +1191,14 @@ void testChainingOfOperatorsWithDifferentMaxParallelism(
configuration.set(
PipelineOptions.OPERATOR_CHAINING_CHAIN_OPERATORS_WITH_DIFFERENT_MAX_PARALLELISM,
chainingOfOperatorsWithDifferentMaxParallelismEnabled);
- configuration.set(PipelineOptions.MAX_PARALLELISM, 10);
+ configuration.set(PipelineOptions.MAX_PARALLELISM, 1);
try (StreamExecutionEnvironment chainEnv =
StreamExecutionEnvironment.createLocalEnvironment(1,
configuration)) {
chainEnv.fromElements(1)
.map(x -> x)
// should automatically break chain here
.map(x -> x)
- .setMaxParallelism(1)
+ .setMaxParallelism(10)
Review Comment:
sounds good 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
