ferenc-csaky commented on PR #21: URL: https://github.com/apache/flink-connector-hbase/pull/21#issuecomment-1781023023
> @ferenc-csaky I rebase the main branch and squash all my changes. > > And one more question master. there will be multiple commits during code reviews, Should I squash all commit into one and apply force push to the origin? Or keep it and wait for the maintainer to squash and merge? I think you can follow whichever path is more comfortable for you and for the specific case at hand. If there are multiple commits in the PR the maintainer will squash it, no problem. @MartijnVisser any thoughts on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
