[
https://issues.apache.org/jira/browse/FLINK-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15647328#comment-15647328
]
ASF GitHub Bot commented on FLINK-4997:
---------------------------------------
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/flink/pull/2756#discussion_r86973108
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/functions/InternalWindowFunction.java
---
@@ -46,5 +46,5 @@
*
* @throws Exception The function may throw exceptions to fail the
program and trigger recovery.
*/
- public abstract void apply(KEY key, W window, IN input, Collector<OUT>
out) throws Exception;
+ public abstract void process(KEY key, W window, IN input,
Collector<OUT> out) throws Exception;
--- End diff --
I think this PR is good as a first step but I really want to see the
benefits of introducing the new interface, especially for users. I don't see
how the window metadata is extended with the current implementation. That's my
$0.02. @aljoscha is more of an expert here.
> Extending Window Function Metadata
> ----------------------------------
>
> Key: FLINK-4997
> URL: https://issues.apache.org/jira/browse/FLINK-4997
> Project: Flink
> Issue Type: New Feature
> Components: DataStream API, Streaming, Windowing Operators
> Reporter: Ventura Del Monte
> Assignee: Ventura Del Monte
> Fix For: 1.2.0
>
>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-2+Extending+Window+Function+Metadata
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
