[ 
https://issues.apache.org/jira/browse/FLINK-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15663971#comment-15663971
 ] 

ASF GitHub Bot commented on FLINK-4997:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2756#discussion_r87802539
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/WindowedStream.java
 ---
    @@ -459,7 +545,28 @@ public WindowedStream(KeyedStream<T, K> input,
         * @param resultType Type information for the result type of the window 
function
         * @return The data stream that is the result of applying the window 
function to the window.
         */
    -   public <R> SingleOutputStreamOperator<R> apply(R initialValue, 
FoldFunction<T, R> foldFunction, WindowFunction<R, R, K, W> function, 
TypeInformation<R> resultType) {
    +   public <R> SingleOutputStreamOperator<R> apply(R initialValue, 
FoldFunction<T, R> foldFunction,
    --- End diff --
    
    I think we can already implement 
https://issues.apache.org/jira/browse/FLINK-3869 (see my last comment there) 
for the `ProcessWindowFunction`. I.e. don't have `apply(ReduceFunction, 
WindowFunction)` but `reduce(ReduceFunction, ProcessWindowFunction)` (same for 
fold).
    
    Also, `apply(R, FoldFunction, WindowFunction)` has a bug, in that it is too 
restrictive, see the Jira issue I linked.


> Extending Window Function Metadata
> ----------------------------------
>
>                 Key: FLINK-4997
>                 URL: https://issues.apache.org/jira/browse/FLINK-4997
>             Project: Flink
>          Issue Type: New Feature
>          Components: DataStream API, Streaming, Windowing Operators
>            Reporter: Ventura Del Monte
>            Assignee: Ventura Del Monte
>             Fix For: 1.2.0
>
>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-2+Extending+Window+Function+Metadata



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to