XComp commented on code in PR #23528:
URL: https://github.com/apache/flink/pull/23528#discussion_r1374531279
##########
flink-end-to-end-tests/test-scripts/common_kubernetes.sh:
##########
@@ -87,6 +94,35 @@ function setup_kubernetes_for_linux {
sudo sysctl fs.protected_regular=0
}
+function retry_download {
+ if [[ "$#" != 3 ]]; then
+ echo "Fatal error: No parameter or too many parameters passed: $@"
+ exit 1;
+ fi
+
+ local download_type download_options download_url download_command
+ download_type="$1"
Review Comment:
Why do we have to support `curl` and `wget`. They are both doing the same
thing (i.e. downloading artifacts). Or what's the reason why you're sticking to
both? AFAIU, we could just pick one of the two and implement the artifact
download in this `retry_download` function without additional parameters
`download_type` and `download_options`. Or am I missing something? :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
