XComp commented on PR #23528:
URL: https://github.com/apache/flink/pull/23528#issuecomment-1788901158

   Thanks for your contribution, @victor9309 . I recommend you to read through 
[Flink's coding 
guidelines](https://flink.apache.org/how-to-contribute/code-style-and-quality-formatting/)
 and follow the pattern of commits properly (in terms of format, casing etc.). 
It might also help to check `git log` to make yourself familiar with the 
correct format. 
   
   Additionally, it would be good to prepare PRs in a way so that I could merge 
them right away. Having the backport PRs being not equal to the parent PR 
requires me to go through the code once more. You might want to look into `git 
cherry-pick`. It looks like you did the backport creation in some manual way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to