RocMarshal commented on code in PR #23635:
URL: https://github.com/apache/flink/pull/23635#discussion_r1378358266
##########
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java:
##########
@@ -708,6 +708,20 @@ public class TaskManagerOptions {
"Time we wait for the timers in milliseconds to
finish all pending timer threads"
+ " when the stream task is cancelled.");
+ public static final ConfigOption<TaskManagerLoadBalanceMode>
TASK_MANAGER_LOAD_BALANCE_MODE =
Review Comment:
hi, @1996fanrui Thank you very much for the precise comments !
I'd prefer the second and after a little adjustment as follows:
1. Add `@Documentation.Section(Documentation.Sections.ALL_TASK_MANAGER)`
2. Temporarily comment out 'SLOT' mode in the `TaskManagerLoadBalanceMode`
3. Add the description about the configuration item like follows:
```
The load balance mode of taskmanager when processing scheduling
tasks.
'NONE' means that the scheduler does not consider any dimensional
balance when scheduling tasks.
'TASKS' means that the scheduler prioritizes ensuring that the
number of tasks on each TM is balanced when scheduling tasks.
Please view FLIP-370 for more details.
```
4. After all PRs merged, we'll add the 'SLOTS' mode back, supplement the
description and deprecate slot-spread-out. the added description would like
follows:
```
'SLOTS' indicates that the scheduler prioritizes and balances the
use of each TM's slot when scheduling tasks.
```
Please let me know what's your opinion~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
