RocMarshal commented on code in PR #23635:
URL: https://github.com/apache/flink/pull/23635#discussion_r1382851909
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SlotSharingExecutionSlotAllocatorFactory.java:
##########
@@ -84,4 +96,25 @@ public ExecutionSlotAllocator createInstance(final
ExecutionSlotAllocationContex
allocationTimeout,
context::getResourceProfile);
}
+
+ private static SlotSharingStrategy.Factory getSlotSharingStrategyFactory(
+ @Nullable Configuration configuration) {
Review Comment:
I checked the parameter passing link. There will be no null values of
`configuration`, I will remove this null-configuration judgment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
