masteryhx commented on PR #23239: URL: https://github.com/apache/flink/pull/23239#issuecomment-1794343153
> Hi @masteryhx , thank you for the review again, I also synced my fork with the upstream, if that was what you meant by 'Could you also rebase all your commits to the master ?' BTW: removing `boolean hasnext = ` created an additional warning on build, that's why I added it in the first place. > > Sincere greeting > > Thias Sorry for the late reply due to my personal business. Thanks for the update. Current PR LGTM. As you could see, there are 6 'Commits'. You could use `git rebase` to the original master and then squash them into one commit. Then after the CI passed, I will merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
