masteryhx commented on PR #23239: URL: https://github.com/apache/flink/pull/23239#issuecomment-1797370868
> > > Hi @masteryhx , thank you for the review again, I also synced my fork with the upstream, if that was what you meant by 'Could you also rebase all your commits to the master ?' BTW: removing `boolean hasnext = ` created an additional warning on build, that's why I added it in the first place. > > > Sincere greeting > > > Thias > > > > > > Sorry for the late reply due to my personal business. Thanks for the update. Current PR LGTM. As you could see, there are 6 'Commits'. You could use `git rebase` to the original master and then squash them into one commit. Then after the CI passed, I will merge it. > > Hi @masteryhx , > > Sorry to bother you, I know how to rebase on my local git, the confusion is with pushing that onto my fork on Github ... If I would do that, I believe, the PR would be force-closed because of the relocated branch. I experienced that a couple of times on our local GitHub Enterprise ... Have you got any more specific instructions on how to avoid this? > > Thias You could try to: 1. use 'git pull <flink-repo> master --rebase' to rebase your local repo 2. use 'git push <your-repo> <your-branch>' to push/force-push to your remote repo then github will update automatically -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
