jnh5y commented on code in PR #23652:
URL: https://github.com/apache/flink/pull/23652#discussion_r1383951328
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/utils/LogicalTypeChecks.java:
##########
@@ -242,6 +245,139 @@ public static boolean hasWellDefinedString(LogicalType
logicalType) {
}
}
+ public static boolean areComparable(
+ LogicalType firstType,
+ LogicalType secondType,
+ StructuredComparison requiredComparison) {
Review Comment:
No wait... is it just because you refactored the code out of
`ComparableTypeStrategy.java`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]