dawidwys commented on code in PR #23652: URL: https://github.com/apache/flink/pull/23652#discussion_r1385059368
########## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/expressions/subquery.scala: ########## @@ -1,78 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ -package org.apache.flink.table.planner.expressions - -import org.apache.flink.api.common.typeinfo.BasicTypeInfo._ -import org.apache.flink.api.common.typeinfo.TypeInformation -import org.apache.flink.table.operations.QueryOperation -import org.apache.flink.table.planner.typeutils.TypeInfoCheckUtils._ -import org.apache.flink.table.planner.validate.{ValidationFailure, ValidationResult, ValidationSuccess} -import org.apache.flink.table.types.utils.TypeConversions -import org.apache.flink.table.types.utils.TypeConversions.fromDataTypeToLegacyInfo - -case class In(expression: PlannerExpression, elements: Seq[PlannerExpression]) - extends PlannerExpression { - - override def toString = s"$expression.in(${elements.mkString(", ")})" - - override private[flink] def children: Seq[PlannerExpression] = expression +: elements.distinct - - override private[flink] def validateInput(): ValidationResult = { - // check if this is a sub-query expression or an element list - elements.head match { - - case TableReference(name, tableOperation: QueryOperation) => - if (elements.length != 1) { - return ValidationFailure("IN operator supports only one table reference.") - } - val resolvedSchema = tableOperation.getResolvedSchema - if (resolvedSchema.getColumnCount > 1) { - return ValidationFailure( - s"The sub-query table '$name' must not have more than one column.") Review Comment: Kind of, yes. We can not check where does the `rightType` originates from at this point. If it is a query or e.g. a `ROW` constructor. We do the matching in `isComparableWithSubQuery` only if it is a `ROW` with a single column though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
