snuyanzin commented on code in PR #23664:
URL: https://github.com/apache/flink/pull/23664#discussion_r1385248937
##########
pom.xml:
##########
@@ -887,7 +887,7 @@ under the License.
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-bom</artifactId>
- <version>4.1.70.Final</version>
+ <version>4.1.100.Final</version>
Review Comment:
Hi @TanYuxin-tyx
thanks for the question
the reason why upgrade of netty and arrow is required is failing of number
of python tests while building with jdk21
I have my own pipepline setup with jdk21
example of error could be seen e.g.
https://dev.azure.com/snuyanzin/flink/_build/results?buildId=2490&view=logs&j=fba17979-6d2e-591d-72f1-97cf42797c11&t=727942b6-6137-54f7-1ef9-e66e706ea068
same error was mentioned in FLINK-33331 description.
Since both netty and arrow require this removed constructor during python
test they both need bumping the version.
By the way here it is the result of same pipeline with cherry-picked commit
from this PR
https://dev.azure.com/snuyanzin/flink/_build/results?buildId=2491&view=results
it could be seen that after that python tests with java 21 are passing.
About the dependency you've mentioned: this dependency is used **only** for
Pekko (former Akka) since current Pekko version can not run with netty 4.x...
At the same time based on tests it is not an issue, looks like they don't used
this removed constructor...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
