Jiabao-Sun commented on PR #23349: URL: https://github.com/apache/flink/pull/23349#issuecomment-1803143808
> Thank for your huge contribution about replacing junit4 with junit5 in table-planner module. The whole pr looks good to me. I mainly have two confusion. > > 1. Is it a good time to remove the dependency in module `table-planner` to avoid other contributor continuing using junit4? > 2. I found that you spent some time to remove `public` for each test functions. But it is a weak constraint for contributor to following this implicit rule. How to make this rule more visible for contributor? (maybe using custom check style or something else) Thanks @xuyangzhong for the hard review. 1. Currently we can't remove junit4 dependencies from table-planner, because there are still some tests using Junit4 and have not been migrated to complete. After all the tests are migrated by Junit5, we can do this. 2. I think we can add this check to ARCH Tests, but it may still need to wait until Junit5 is fully migrated. Please help check it again when you have time. Thanks again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
