Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2732#discussion_r87050071
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/RemoteExecutor.java ---
@@ -207,14 +207,23 @@ public JobExecutionResult
executePlanWithJars(JobWithJars program) throws Except
shutDownAtEnd = false;
}
- try {
- return client.run(program,
defaultParallelism).getJobExecutionResult();
- }
- finally {
- if (shutDownAtEnd) {
- stop();
- }
- }
+ final JobClient jobClient = client.run(program,
defaultParallelism);
+
+ jobClient.addFinalizer(
+ new Runnable() {
+ @Override
+ public void run() {
+ if (shutDownAtEnd) {
+ try {
+ stop();
+ } catch (Exception e) {
+ throw new
RuntimeException("Failed to clean up.", e);
--- End diff --
Same here with the exception. I think it is not a good practice to
masquerade checked exceptions as unchecked exceptions, because it makes it
violates the contract defined by the `Runnable` interface.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
