XComp commented on code in PR #23773:
URL: https://github.com/apache/flink/pull/23773#discussion_r1402250278
##########
flink-runtime/src/main/java/org/apache/flink/runtime/leaderretrieval/ZooKeeperLeaderRetrievalDriver.java:
##########
@@ -69,8 +68,40 @@ public class ZooKeeperLeaderRetrievalDriver implements
LeaderRetrievalDriver {
private final FatalErrorHandler fatalErrorHandler;
+ /**
+ * Each {@code ZooKeeperLeaderRetrievalDriver} has its own watcher
initialized. There is a bug
Review Comment:
> This change is meant as a draft and should rather be used as a base for a
discussion whether
[FLINK-33053](https://issues.apache.org/jira/browse/FLINK-33053) is actually an
issue that should be addressed in Flink itself. As far as I understand, the
thread leakage is only happening in test code when the ZooKeeper test server
implementation is set up.
@KarmaGYZ Is it correct that the thread leakage happens in ZooKeeper's
TestServer implementation? :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
