XComp commented on code in PR #23773:
URL: https://github.com/apache/flink/pull/23773#discussion_r1403015737
##########
flink-runtime/src/main/java/org/apache/flink/runtime/leaderretrieval/ZooKeeperLeaderRetrievalDriver.java:
##########
@@ -69,8 +68,40 @@ public class ZooKeeperLeaderRetrievalDriver implements
LeaderRetrievalDriver {
private final FatalErrorHandler fatalErrorHandler;
+ /**
+ * Each {@code ZooKeeperLeaderRetrievalDriver} has its own watcher
initialized. There is a bug
Review Comment:
I'm just asking because you mentioned in the description of FLINK-33053 that
you observed the issue in stress tests. Did you use the MiniCluster and
ZooKeeper in a single JVM or did you have your ZooKeeper deployed separately
for the stress tests?
I'd like to understand whether it's on the ZooKeeper side (that's how it
sounds to me right now) or on the Flink/Curator side. If I misunderstood the
discussion in FLINK-33053 and the related PR #23415 and it's not a ZooKeeper
server issue, fixing it on the Flink side is reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
