leonardBang commented on code in PR #23775:
URL: https://github.com/apache/flink/pull/23775#discussion_r1402980163
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TableSinkITCase.scala:
##########
@@ -255,7 +253,7 @@ class TableSinkITCase(mode: StateBackendMode) extends
StreamingWithStateTestBase
"+I[jason, 1, null, null, null, null]",
"+I[jason, 1, null, null, null, null]"
)
- assertEquals(expected.sorted, result.sorted)
+ assertThat(result.sorted).isEqualTo(expected.sorted)
Review Comment:
Could we remove junit4 dependency in table-planner to make sure we have
migrated all tests ?
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/TableEnvironmentITCase.scala:
##########
@@ -76,7 +76,7 @@ class TableEnvironmentITCase(tableEnvName: String,
isStreaming: Boolean) extends
TestTableSourceSinks.createPersonCsvTemporaryTable(tEnv, "MyTable")
}
- @Test
+ @TestTemplate
Review Comment:
I found some tests use `TestTemplate` annotation with
`ParameterizedTestExtension`,some tests use `Test` annotation with
`ParameterizedTestExtension`, IIUC, we should use `TestTemplate` for all tests
with `ParameterizedTestExtension`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
