Jiabao-Sun commented on code in PR #23775:
URL: https://github.com/apache/flink/pull/23775#discussion_r1403027595
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TableSinkITCase.scala:
##########
@@ -255,7 +253,7 @@ class TableSinkITCase(mode: StateBackendMode) extends
StreamingWithStateTestBase
"+I[jason, 1, null, null, null, null]",
"+I[jason, 1, null, null, null, null]"
)
- assertEquals(expected.sorted, result.sorted)
+ assertThat(result.sorted).isEqualTo(expected.sorted)
Review Comment:
Currently, it is very difficult to remove JUnit4 because its dependency is
imported from `flink-parent`. To remove the dependency, it may be necessary to
declare JUnit4 as `optional` in `flink-parent` and then add JUnit4 dependency
to the submodules as needed.
To avoid adding JUnit 4 tests in the `flink-table-planner` module, I'm
wondering if we can add `ArchUnit` rules as a transitional solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
