[
https://issues.apache.org/jira/browse/FLINK-25857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789988#comment-17789988
]
Weijie Guo commented on FLINK-25857:
------------------------------------
[~pvary], Well, sorry, I didn't realize we already had a FLIP discussing this
(FLIP-371).
In fact, my main concern is that the current approach seems to be inconsistent
with the deprecation process for PublicEvolving API in FLIP-321[1]. In other
words, this ticket is a zero migration period. I understand the diamond
inheritance problem you pointed out, but I would have preferred to see a
solution that was properly deprecated (which may require more subtle design).
I don't mean to question existing efforts, I just feel that we should do our
best to comply with the work like FLIP-321 (which is probably also being pushed
concurrently when you start this work, so not realizing it exists at first
isn't your problem :) )
Maybe we need to take some time to think about whether we can find a win-win
solution. After all, there is still plenty of time before the release of 1.19.
If it is indeed impossible to implement, it's fine for me, but don't forget to
remind the connector owner to release a compatible new version.
[1]
https://cwiki.apache.org/confluence/display/FLINK/FLIP-321%3A+Introduce+an+API+deprecation+process
> Add committer metrics to track the status of committables
> ---------------------------------------------------------
>
> Key: FLINK-25857
> URL: https://issues.apache.org/jira/browse/FLINK-25857
> Project: Flink
> Issue Type: Sub-task
> Components: Connectors / Common
> Reporter: Fabian Paul
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.19.0
>
> Attachments: image-2023-10-20-17-23-09-595.png, screenshot-1.png
>
>
> With Sink V2 we can now track the progress of a committable during committing
> and show metrics about the committing status. (i.e. failed, retried,
> succeeded).
> The voted FLIP
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-371%3A+Provide+initialization+context+for+Committer+creation+in+TwoPhaseCommittingSink
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
