[
https://issues.apache.org/jira/browse/FLINK-25857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790007#comment-17790007
]
Márton Balassi commented on FLINK-25857:
----------------------------------------
Hi team,
Thanks for looking into this. I am working with [~pvary] on this effort and
acknowledge it that we deviated from the original design of FLIP-371, strictly
based on the comments we received during the PR.
[~leonard] : [~jiabao.sun] raised his concern *after* I merged the PR, I would
not have merged the PR with such an important concern not being answered.
Please allow a couple days for [~pvary] and myself to gather all input and
weigh our options. This runs deeper than this specific change, which we can
return to the original design - this change ended up being a test for both
FLIP-321 (which does not seem to be fully implemented even though the vote has
passed) and the connector externalization. More important than the specifics we
need to find a consensus for these (the decisions can be decoupled).
> Add committer metrics to track the status of committables
> ---------------------------------------------------------
>
> Key: FLINK-25857
> URL: https://issues.apache.org/jira/browse/FLINK-25857
> Project: Flink
> Issue Type: Sub-task
> Components: Connectors / Common
> Reporter: Fabian Paul
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.19.0
>
> Attachments: image-2023-10-20-17-23-09-595.png, screenshot-1.png
>
>
> With Sink V2 we can now track the progress of a committable during committing
> and show metrics about the committing status. (i.e. failed, retried,
> succeeded).
> The voted FLIP
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-371%3A+Provide+initialization+context+for+Committer+creation+in+TwoPhaseCommittingSink
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
