twalthr commented on code in PR #23680:
URL: https://github.com/apache/flink/pull/23680#discussion_r1410493959
##########
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/SinkTestStep.java:
##########
@@ -106,6 +113,8 @@ public static final class Builder extends
AbstractBuilder<Builder> {
private List<String> expectedBeforeRestoreStrings;
private List<String> expectedAfterRestoreStrings;
+ private boolean testRawData = true;
Review Comment:
I would select materialied data as the default to avoid flaky tests, every
change in paralellism (e.g. going from 4 to 1) or multiple inputs will produce
non-deterministic results. only the materialized result is safe to use for all
cases.
##########
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/SinkTestStep.java:
##########
@@ -106,6 +113,8 @@ public static final class Builder extends
AbstractBuilder<Builder> {
private List<String> expectedBeforeRestoreStrings;
private List<String> expectedAfterRestoreStrings;
+ private boolean testRawData = true;
Review Comment:
I would select materialized data as the default to avoid flaky tests, every
change in paralellism (e.g. going from 4 to 1) or multiple inputs will produce
non-deterministic results. only the materialized result is safe to use for all
cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
