jnh5y commented on code in PR #23680:
URL: https://github.com/apache/flink/pull/23680#discussion_r1410763255
##########
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/SinkTestStep.java:
##########
@@ -106,6 +113,8 @@ public static final class Builder extends
AbstractBuilder<Builder> {
private List<String> expectedBeforeRestoreStrings;
private List<String> expectedAfterRestoreStrings;
+ private boolean testRawData = true;
Review Comment:
After some reflection, I'd point out that changing the default behavior
would introduce changes to tests not related to the joins and also potentially
impact the other RestoreTest PRs.
Between those two considerations, I think leaving it as-is is probably best.
If we really want to change the default, I'd suggest we do that as a
separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
