1996fanrui opened a new pull request, #23850:
URL: https://github.com/apache/flink/pull/23850
## What is the purpose of the change
FLINK-21945 will convert the unaligned checkpoint barrier and timeoutable
aligned checkpoint barrier to force aligned barrier. However, Force aligned
barrier logic doesn't work for timeoutable aligned checkpoint barrier.
Bug at
org.apache.flink.streaming.runtime.io.RecordWriterOutput#broadcastEvent, we
will call withUnalignedUnsupported to convert the unaligned checkpoint barrier
to FORCED_ALIGNED barrier when the supportsUnalignedCheckpoints is false.
However, the if has one condition: isPriorityEvent. When aligned checkpoint
timeout is enabled, flink will emit one timeoutable barrier. It isn't
PriorityEvent.
## Brief change log
[FLINK-33693][checkpoint] Force aligned barrier works with timeoutable
aligned checkpoint barrier
- Remove the condition: isPriorityEvent
## Verifying this change
This change added tests and can be verified as follows:
- `Added test: `RecordWriterOutputTest#testDisableUnalignedCheckpoint`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector:no
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
