mxm commented on code in PR #721:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/721#discussion_r1414073148


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java:
##########
@@ -186,7 +187,41 @@ private void applyAutoscaler(FlinkResourceContext<CR> ctx) 
throws Exception {
                 ctx.getResource().getSpec().getJob() != null
                         && 
ctx.getObserveConfig().getBoolean(AUTOSCALER_ENABLED);
         autoScalerCtx.getConfiguration().set(AUTOSCALER_ENABLED, 
autoscalerEnabled);
+
         autoscaler.scale(autoScalerCtx);
+        putBackOldParallelismOverridesIfNewOnesAreMerelyAPermutation(ctx);
+    }
+
+    private static <
+                    CR extends AbstractFlinkResource<SPEC, STATUS>,
+                    SPEC extends AbstractFlinkSpec,
+                    STATUS extends CommonStatus<SPEC>>
+            void putBackOldParallelismOverridesIfNewOnesAreMerelyAPermutation(

Review Comment:
   It's not possible to add the change there because we do not have access to 
the current overrides.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to