1996fanrui commented on code in PR #721:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/721#discussion_r1415657657
##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/autoscaler/KubernetesScalingRealizerTest.java:
##########
@@ -30,12 +31,23 @@
public class KubernetesScalingRealizerTest {
@Test
- public void testAutoscalerOverridesVertexIdsAreSorted() {
-
+ public void
testAutoscalerOverridesStringDoesNotChangeUnlessOverridesChange() {
KubernetesJobAutoScalerContext ctx =
TestingKubernetesAutoscalerUtils.createContext("test", null);
+ FlinkDeployment resource = (FlinkDeployment) ctx.getResource();
+
+ // Create resource with existing parallelism overrides
+ resource.getSpec()
+ .getFlinkConfiguration()
+ .put(PipelineOptions.PARALLELISM_OVERRIDES.key(), "a:1,b:2");
Review Comment:
Could we test `"a:1,b:2"` and `"b:2,a:1"`?
Also, the `assertThat` have "a:1,b:2"` as well, it's better to extract
an field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
