singhravidutt commented on code in PR #23489: URL: https://github.com/apache/flink/pull/23489#discussion_r1425171966
##########
flink-filesystems/flink-gs-fs-hadoop/pom.xml:
##########
@@ -188,6 +212,29 @@ under the License.
<goal>shade</goal>
</goals>
<configuration>
+ <filters>
+ <filter>
+
<artifact>org.apache.flink:flink-fs-hadoop-shaded</artifact>
+
<excludes>
+
<exclude>com/google/common/**</exclude>
+
<exclude>org/checkerframework/**</exclude>
+
<exclude>com/google/errorprone/**</exclude>
+
<exclude>com/google/j2objc/**</exclude>
+
<exclude>com/google/thirdparty/publicsuffix/**</exclude>
+
</excludes>
+ </filter>
+ <filter>
+
<artifact>*</artifact>
+
<excludes>
+
<exclude>properties.dtd</exclude>
+
<exclude>PropertyList-1.0.dtd</exclude>
+
<exclude>mozilla/**</exclude>
+
<exclude>META-INF/maven/**</exclude>
+
<exclude>META-INF/NOTICE.txt</exclude>
+
<exclude>META-INF/LICENSE.txt</exclude>
+
</excludes>
+ </filter>
+ </filters>
Review Comment:
`flink-fs-hadoop-shaded` is a shaded jar which doesn't relocate the classes
mention in the exclusion rules here. The only way I see we can exclude them is
by mentioning them explicitly here.
##########
flink-filesystems/flink-gs-fs-hadoop/pom.xml:
##########
@@ -204,20 +251,13 @@ under the License.
<pattern>org.apache.flink.runtime.util</pattern>
<shadedPattern>org.apache.flink.fs.gs.org.apache.flink.runtime.util</shadedPattern>
</relocation>
+ <!-- shade
google guava version-->
+ <relocation>
+
<pattern>com.google.common</pattern>
+
<shadedPattern>org.apache.flink.fs.gs.com.google.common</shadedPattern>
Review Comment:
With shading it would rewrite the import:`com.google.common` in classes of
module:`flink-gs-fs-hadoop`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
