XComp commented on code in PR #23880:
URL: https://github.com/apache/flink/pull/23880#discussion_r1426546494
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/JobGraphWriter.java:
##########
@@ -37,6 +38,18 @@ public interface JobGraphWriter extends
LocallyCleanableResource, GloballyCleana
*/
void putJobGraph(JobGraph jobGraph) throws Exception;
+ /**
+ * Adds the {@link JobGraph} instance and have write operations performed
asynchronously in
+ * ioExecutor of Dispatcher
+ *
+ * @param jobGraph
+ * @param ioExecutor
+ * @return
+ * @throws Exception
+ */
+ CompletableFuture<Void> putJobGraphAsync(JobGraph jobGraph,
Optional<Executor> ioExecutor)
Review Comment:
Can you elaborate a bit more on your claim? Is it because you have to modify
the interface for that change?
If you're concerned about chaning the interface: `JobGraphWriter` is an
internally used interface (i.e. not marked in any way as `@Public` or
`@PublicEvolving`). Additionally, it's not really exposed to users in any way I
could think. In this sense, modifying the interface in order to improve the
overall code base (rather than introducing some workarounds) seems like a
reasonable approach. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
