JingGe commented on code in PR #23949:
URL: https://github.com/apache/flink/pull/23949#discussion_r1430093209
##########
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java:
##########
@@ -683,6 +685,69 @@ public void testRetrieveCheckpointStats() throws Exception
{
Assertions.assertThat(resultsFuture).isCompletedWithValue(snapshot);
}
+ @Test
+ public void testRetrieveCheckpointStatsOnCompletedJob() throws Exception {
+ CheckpointStatsSnapshot snapshot =
getTestCheckpointStatsSnapshotWithTwoFailedCheckpoints();
+ TestingJobMasterGateway testingJobMasterGateway =
+ new TestingJobMasterGatewayBuilder().build();
+
+ dispatcher =
+ createAndStartDispatcher(
+ heartbeatServices,
+ haServices,
+ new TestingJobMasterGatewayJobManagerRunnerFactory(
+ testingJobMasterGateway));
+
+ final JobStatus expectedState = JobStatus.FAILED;
Review Comment:
Did you have issues with other completed jobs i.e. CANCELED, FINISHED? Does
it make sense to test them too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
