hlteoh37 commented on code in PR #23949:
URL: https://github.com/apache/flink/pull/23949#discussion_r1430115941
##########
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java:
##########
@@ -904,29 +904,32 @@ public CompletableFuture<JobStatus>
requestJobStatus(JobID jobId, Time timeout)
@Override
public CompletableFuture<ExecutionGraphInfo> requestExecutionGraphInfo(
JobID jobId, Time timeout) {
- Function<Throwable, ExecutionGraphInfo>
checkExecutionGraphStoreOnException =
- throwable -> {
- // check whether it is a completed job
- final ExecutionGraphInfo executionGraphInfo =
- executionGraphInfoStore.get(jobId);
- if (executionGraphInfo == null) {
- throw new CompletionException(
-
ExceptionUtils.stripCompletionException(throwable));
- } else {
- return executionGraphInfo;
- }
- };
Optional<JobManagerRunner> maybeJob = getJobManagerRunner(jobId);
return maybeJob.map(job -> job.requestJob(timeout))
.orElse(FutureUtils.completedExceptionally(new
FlinkJobNotFoundException(jobId)))
- .exceptionally(checkExecutionGraphStoreOnException);
+ .exceptionally(t -> checkExecutionGraphStoreOnException(t,
jobId));
+ }
+
+ private ExecutionGraphInfo checkExecutionGraphStoreOnException(Throwable
t, JobID jobId) {
Review Comment:
Will rename.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]