dannycranmer opened a new pull request, #121:
URL: https://github.com/apache/flink-connector-aws/pull/121

   ## Purpose of the change
   
   Inspired by https://github.com/apache/flink-connector-kafka/pull/69, moves 
`kinesis.py` and `test_kinesis.py` from `apache/flink` to 
`apache/flink-connector-aws`. 
   
   When running `mvn clean install` downloads the testing infra scripts from 
the main Flink repo (flink-python/dev/build-wheels.sh, 
flink-python/dev/install_command.sh, flink-python/dev/lint-python.sh)
   
   ## Verifying this change
   
   Tests can be run by the following commands:
   
   ```
   cd flink-python-connector-aws
   chmod a+x dev/* 
   ./dev/lint-python.sh -e mypy,sphinx
   ```
   
   Additionally I have build the archive via `./dev/build-wheels.sh` and then 
included in a local sample app that consumes from Kinesis and prints to 
terminal.
   
   ## Significant changes
   *(Please check any boxes [x] if the answer is "yes". You can first publish 
the PR and check them afterwards, for convenience.)*
   - [ ] Dependencies have been added or upgraded
   - [ ] Public API has been changed (Public API is any class annotated with 
`@Public(Evolving)`)
   - [ ] Serializers have been changed
   - [ ] New feature has been introduced
     - If yes, how is this documented? (not applicable / docs / JavaDocs / not 
documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to