liuyongvs commented on code in PR #24015:
URL: https://github.com/apache/flink/pull/24015#discussion_r1439140313
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/batch/BatchExecOverAggregate.java:
##########
@@ -231,7 +233,7 @@ private List<OverWindowFrame> createOverWindowFrames(
GeneratedAggsHandleFunction genAggsHandler =
generator
.needAccumulate()
- .needRetract()
+ .needRetract(aggCallNeedRetractions)
Review Comment:
comments : we may not use retract in batch sql, but i found
OffsetOverFrame(belongs to BatchExecOverAggregate) use retract function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
