liuyongvs commented on code in PR #24015:
URL: https://github.com/apache/flink/pull/24015#discussion_r1439141361
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecLocalGroupAggregate.java:
##########
@@ -147,7 +147,7 @@ protected Transformation<RowData> translateToPlanInternal(
true);
generator.needAccumulate().needMerge(0, true, null);
if (needRetraction) {
- generator.needRetract();
+ generator.needRetract(aggCallNeedRetractions);
}
Review Comment:
1. why global agg doesn't need retract method? because agg when enable two
stage. the global agg doesn't receive retract msg, so only local agg using
retract
2. why window WTF doesn't need retract method? because Window WTF can not
process update msg now. it will supports later
3. why group window agg doesn't need retract method? because the group
window agg doesn't support two stage in flink, but supports on blink
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
