JunRuiLee commented on code in PR #24025:
URL: https://github.com/apache/flink/pull/24025#discussion_r1442658972
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java:
##########
@@ -614,7 +563,9 @@ private Collection<Integer>
legacyTransform(Transformation<?> transform) {
if (transform.getBufferTimeout() >= 0) {
streamGraph.setBufferTimeout(transform.getId(),
transform.getBufferTimeout());
} else {
- streamGraph.setBufferTimeout(transform.getId(),
defaultBufferTimeout);
+ streamGraph.setBufferTimeout(
+ transform.getId(),
+
configuration.get(ExecutionOptions.BUFFER_TIMEOUT).toMillis());
Review Comment:
Good catch, there was an issue with my handling of BUFFER_TIMEOUT_ENABLED.
In fact, what I intended to implement was that whenever getting the buffer
timeout from the configuration, we need to first check BUFFER_TIMEOUT_ENABLED;
the same applies to setting the buffer timeout in the configuration. Thanks for
pointing out the issue, it has now been fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
