1996fanrui commented on code in PR #24025:
URL: https://github.com/apache/flink/pull/24025#discussion_r1442704443
##########
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##########
@@ -1201,6 +1212,9 @@ public void configure(ReadableConfig configuration,
ClassLoader classLoader) {
.getOptional(ExecutionOptions.SNAPSHOT_COMPRESSION)
.ifPresent(this::setUseSnapshotCompression);
RestartStrategies.fromConfiguration(configuration).ifPresent(this::setRestartStrategy);
+ configuration
+ .getOptional(RestartStrategyOptions.RESTART_STRATEGY)
+ .ifPresent(s -> this.setRestartStrategy(configuration));
Review Comment:
I don't know why removing it. If it's removed, on one calls `private void
setRestartStrategy(ReadableConfig configuration) {`, right? And all options
cannot be added to configuration of ExecutionConfig.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
