jiangxin369 commented on code in PR #23977:
URL: https://github.com/apache/flink/pull/23977#discussion_r1443960924
##########
flink-runtime/src/test/java/org/apache/flink/runtime/minicluster/MiniClusterITCase.java:
##########
@@ -127,6 +129,11 @@ private void runHandleJobsWhenNotEnoughSlots(final
JobGraph jobGraph) throws Exc
configuration.setLong(JobManagerOptions.SLOT_REQUEST_TIMEOUT, 100L);
// this triggers the failure for the adaptive scheduler
configuration.set(JobManagerOptions.RESOURCE_WAIT_TIMEOUT,
Duration.ofMillis(100));
+ // disable the resource requirements check from slot manager the make
sure the scheduler
+ // cannot acquire slots until timeout.
+ configuration.set(
Review Comment:
Thanks for the review. Indeed I can reproduce your question and the test is
not finalized as expected. I think the reason is that the standalone resource
manager is also using this config as a start up period. We can prove it by
manually changing the
`configuration.getLong(JobManagerOptions.SLOT_REQUEST_TIMEOUT)` in
`ConfigurationUtils#getStandaloneClusterStartupPeriodTime` to `1ms` but keeping
the `JobManagerOptions.SLOT_REQUEST_TIMEOUT` with 10000. Then the test would
finalize earlier as expected.
```
public static Time getStandaloneClusterStartupPeriodTime(Configuration
configuration) {
final Time timeout;
long standaloneClusterStartupPeriodTime =
configuration.getLong(
ResourceManagerOptions.STANDALONE_CLUSTER_STARTUP_PERIOD_TIME);
if (standaloneClusterStartupPeriodTime >= 0) {
timeout = Time.milliseconds(standaloneClusterStartupPeriodTime);
} else {
timeout = Time.milliseconds(1);
}
return timeout;
}
```
Currently, I'm not sure if it is a reasonable behavior of standalone
resource manager, do you have any idea? If it is not reasonable, I think we can
track it in another issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
