XComp commented on code in PR #23964:
URL: https://github.com/apache/flink/pull/23964#discussion_r1445933504
##########
tools/azure-pipelines/debug_files_utils.sh:
##########
@@ -21,7 +21,11 @@ function prepare_debug_files {
MODULE=$@
export DEBUG_FILES_OUTPUT_DIR="$AGENT_TEMPDIRECTORY/debug_files"
export DEBUG_FILES_NAME="$(echo $MODULE | tr -c '[:alnum:]\n\r'
'_')-$(date +%s)"
+ # make environment variables available in AzureCI workflow
configurations
echo "##vso[task.setvariable
variable=DEBUG_FILES_OUTPUT_DIR]$DEBUG_FILES_OUTPUT_DIR"
echo "##vso[task.setvariable
variable=DEBUG_FILES_NAME]$DEBUG_FILES_NAME"
+ # make environment variables available in Github Actions workflow
configuration
+ echo "debug-files-output-dir=${DEBUG_FILES_OUTPUT_DIR}" >>
$GITHUB_OUTPUT
+ echo "debug-files-name=${DEBUG_FILES_NAME}" >> $GITHUB_OUTPUT
Review Comment:
That's actually a valid question. tbh, I assumed that `>>` operator would
also work with environment variables and didn't question this command. But
indeed, a local check revealed that `>> $FOO` requires to have a file path
being stored under `FOO`.
Interestingly, Azure Pipelines doesn't complain even though it should.
:thinking: The only explanation I have is that they have this env variable also
set in Azure Pipeline environments (maybe, because Azure and GHA share the same
backend).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
