XComp commented on code in PR #23964:
URL: https://github.com/apache/flink/pull/23964#discussion_r1446109591
##########
tools/azure-pipelines/debug_files_utils.sh:
##########
@@ -21,7 +21,15 @@ function prepare_debug_files {
MODULE=$@
export DEBUG_FILES_OUTPUT_DIR="$AGENT_TEMPDIRECTORY/debug_files"
export DEBUG_FILES_NAME="$(echo $MODULE | tr -c '[:alnum:]\n\r'
'_')-$(date +%s)"
+ # make environment variables available in AzureCI workflow
configurations
echo "##vso[task.setvariable
variable=DEBUG_FILES_OUTPUT_DIR]$DEBUG_FILES_OUTPUT_DIR"
echo "##vso[task.setvariable
variable=DEBUG_FILES_NAME]$DEBUG_FILES_NAME"
+
+ # make environment variables available in Github Actions workflow
configuration
+ if [ ! -z "${GITHUB_OUTPUT+x}" ] && [ -f "$GITHUB_OUTPUT" ]; then
Review Comment:
I see - the [change in the upstream
PR](https://github.com/apache/flink/pull/23970#discussion_r1445909482) actually
resolves the issue.
##########
tools/azure-pipelines/debug_files_utils.sh:
##########
@@ -21,7 +21,15 @@ function prepare_debug_files {
MODULE=$@
export DEBUG_FILES_OUTPUT_DIR="$AGENT_TEMPDIRECTORY/debug_files"
export DEBUG_FILES_NAME="$(echo $MODULE | tr -c '[:alnum:]\n\r'
'_')-$(date +%s)"
+ # make environment variables available in AzureCI workflow
configurations
echo "##vso[task.setvariable
variable=DEBUG_FILES_OUTPUT_DIR]$DEBUG_FILES_OUTPUT_DIR"
echo "##vso[task.setvariable
variable=DEBUG_FILES_NAME]$DEBUG_FILES_NAME"
+
+ # make environment variables available in Github Actions workflow
configuration
+ if [ ! -z "${GITHUB_OUTPUT+x}" ] && [ -f "$GITHUB_OUTPUT" ]; then
Review Comment:
I am puzzled now why this works in general. We were relying on
`$AGENT_TEMPDIRECTORY` (which is an Azure Pipeline env variable; see [Azure
Pipeline
docs](https://learn.microsoft.com/en-us/azure/devops/pipelines/build/variables?view=azure-devops&tabs=yaml#agent-variables-devops-services))
for the GHA workflows. The corresponding GHA env variable would be
`$RUNNER_TEMP` (see [GHA
docs](https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables)).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
