xuyangzhong commented on code in PR #24030:
URL: https://github.com/apache/flink/pull/24030#discussion_r1448518581


##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/agg/WindowAggregateTest.scala:
##########
@@ -127,6 +162,26 @@ class WindowAggregateTest(aggPhaseEnforcer: 
AggregatePhaseStrategy) extends Tabl
     util.verifyRelPlan(sql)
   }
 
+  @TestTemplate
+  def testTumble_OnProctimeWithCDCSource(): Unit = {
+    assumeThat(isTwoPhase).isTrue

Review Comment:
   Because currently, we don't support two-phase optimization for window agg 
while using proctime. Although we only test two-stage, but the plan is same 
with the result of one-phase. Not testing one-phase may help to reduce the size 
of the xml.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to