xuyangzhong commented on PR #24030: URL: https://github.com/apache/flink/pull/24030#issuecomment-1886682935
Hi, @LadyForest thanks for your patient review. > One suggestion is to split table-runtime and table-planner changes into two smaller commits to ease the review. Great suggestion! The reason I don't split this big pr into two commits, runtime and planner, is as following: 1. There are not many changes to the pure runtime part. This pr looks like too big is because the auto-generated files by json plan test, and this part takes up nearly 3000 lines. That means these big files will be added to the planner commits section. 2. If splitting commits, we may first has a commit with runtime, then planner. But the harness test for runtime operator depends on planner. But anyway, I appreciate your advice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
