StefanRRichter commented on code in PR #24023:
URL: https://github.com/apache/flink/pull/24023#discussion_r1448564562
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/memory/MemoryStateBackend.java:
##########
@@ -65,8 +54,8 @@
*
* <pre>{@code
* StreamExecutionEnvironment env =
StreamExecutionEnvironment.getExecutionEnvironment();
- * env.setStateBackend(new HashMapStateBackend());
- * env.getCheckpointConfig().setCheckpointStorage(new
JobManagerCheckpointStorage());
+ * parameters.getEnv().setStateBackend(new HashMapStateBackend());
Review Comment:
Change to the comment looks wrong.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/StateBackend.java:
##########
@@ -94,90 +95,27 @@ default String getName() {
*
* <p><i>Keyed State</i> is state where each value is bound to a key.
*
- * @param env The environment of the task.
- * @param jobID The ID of the job that the task belongs to.
- * @param operatorIdentifier The identifier text of the operator.
- * @param keySerializer The key-serializer for the operator.
- * @param numberOfKeyGroups The number of key-groups aka max parallelism.
- * @param keyGroupRange Range of key-groups for which the to-be-created
backend is responsible.
- * @param kvStateRegistry KvStateRegistry helper for this task.
- * @param ttlTimeProvider Provider for TTL logic to judge about state
expiration.
- * @param metricGroup The parent metric group for all state backend
metrics.
- * @param stateHandles The state handles for restore.
- * @param cancelStreamRegistry The registry to which created closeable
objects will be
- * registered during restore.
+ * @param parameters accessor.
Review Comment:
The doc for this argument is "accessor" everywhere, what does that even
mean? Why not "argument bundle for creating ...." or something like that
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateDownloader.java:
##########
@@ -41,8 +43,14 @@
/** Help class for downloading RocksDB state files. */
public class RocksDBStateDownloader extends RocksDBStateDataTransfer {
- public RocksDBStateDownloader(int restoringThreadNum) {
+ static final String DOWNLOAD_DURATION_STATE_METRIC =
"DownloadStateDurationMs";
Review Comment:
Should we rather keep all (present and future) init metrics key in a
dedicated class instead of scattered around?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
