pnowojski commented on code in PR #24023:
URL: https://github.com/apache/flink/pull/24023#discussion_r1448861339
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateDownloader.java:
##########
@@ -41,8 +43,14 @@
/** Help class for downloading RocksDB state files. */
public class RocksDBStateDownloader extends RocksDBStateDataTransfer {
- public RocksDBStateDownloader(int restoringThreadNum) {
+ static final String DOWNLOAD_DURATION_STATE_METRIC =
"DownloadStateDurationMs";
Review Comment:
My thinking was that this is a custom RocksDB's metric, so it should be
named in the rocksdb module. But on a second thought, moving this name away to
`MetricNames` doesn't hurt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
