ferenc-csaky commented on PR #24065: URL: https://github.com/apache/flink/pull/24065#issuecomment-1886932466
> Thanks @ferenc-csaky, I like this approach to the feature and thanks for preserving the prior work of @SwimSweet in separate commits (I might squash his 2 into a single commit later). On cursory look could you please update the docs too? I will review further later. Thank you for the review @mbalassi! Yes, I'll update the docs, furthermore I would like to highlight one thing regarding the current implementation that might be discussed a bit further: Currently, for standalone app mode, the `--jars` arg handles both the job JAR and any additional artifact, which is a nice approach IMO, although it has some downsides: 1. The argument number is unlimited (as a job can have N additional dependency), so if someone puts the `--jars` CLI option last and tries to pass positional args afterwards all of those will be handled as "jars", for example `... --jars myjob.jar posarg1 posarg2`. This behavior could cause some confusion. 2. Because the additional artifacts are not differentiated from the job JAR, the fetching logic gets a bit more complicated. I started thinking about using the newly introduced option as a dynamic property for standalone mode as well. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
