1996fanrui commented on code in PR #741:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/741#discussion_r1452222878
##########
flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/config/AutoscalerStandaloneOptions.java:
##########
@@ -59,4 +64,47 @@ private static ConfigOptions.OptionBuilder
autoscalerStandaloneConfig(String key
.withDeprecatedKeys("flinkClusterPort")
.withDescription(
"The port of flink cluster when the flink-cluster
fetcher is used.");
+
+ public static final ConfigOption<StateStoreType> STATE_STORE_TYPE =
+ autoscalerStandaloneConfig("state-store.type")
+ .enumType(StateStoreType.class)
+ .defaultValue(StateStoreType.MEMORY)
+ .withDescription("The autoscaler state store type.");
+
+ public static final ConfigOption<String> STATE_STORE_JDBC_URL =
+ autoscalerStandaloneConfig("state-store.jdbc.url")
+ .stringType()
+ .noDefaultValue()
+ .withDescription(
+ Description.builder()
+ .text(
+ "The jdbc url of jdbc state store
when %s has been set to %s, such as: %s.",
+ code(STATE_STORE_TYPE.key()),
+ code(JDBC.toString()),
+
code("jdbc:mysql://localhost:3306/flink_autoscaler"))
+ .linebreak()
+ .text("This option is required when using
JDBC state store.")
+ .build());
+
+ public static final ConfigOption<String> STATE_STORE_JDBC_USERNAME =
+ autoscalerStandaloneConfig("state-store.jdbc.username")
+ .stringType()
+ .noDefaultValue()
+ .withDescription(
+ Description.builder()
+ .text(
+ "The jdbc username of jdbc state
store when %s has been set to %s.",
+ code(STATE_STORE_TYPE.key()),
code(JDBC.toString()))
+ .build());
+
+ public static final ConfigOption<String> STATE_STORE_JDBC_PASSWORD =
+ autoscalerStandaloneConfig("state-store.jdbc.password")
Review Comment:
Sounds make sense to encrypt it.
> secret
Do you have any recommended secret systems?
> env
Do you mean setting the password to the environment variable in advanced and
Autoscaler standalone get the password from environment variable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
