Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2789#discussion_r88264932
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/Kafka09Fetcher.java
---
@@ -143,133 +123,26 @@ public Kafka09Fetcher(
@Override
public void runFetchLoop() throws Exception {
--- End diff --
To be safe, I think the `CloseExceptions` should be re-thrown, as should
all others.
Just for the case when we overlook something and the consumer thread could
close the handover by itself or so. Any abnormal termination of the fetch loop
should result in an exception - that is the safest we can do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
