Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2789#discussion_r88273352
  
    --- Diff: 
flink-streaming-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/Kafka09Fetcher.java
 ---
    @@ -143,133 +123,26 @@ public Kafka09Fetcher(
     
        @Override
        public void runFetchLoop() throws Exception {
    --- End diff --
    
    Ok, I agree to be safe.
    
    Also, I just realized that "end of stream" shouldn't lead to the 
`ClosedException`, only "cancellation", "fetcher error", "consumer error", and 
(hopefully not) any other stuff we overlooked will. So, basically, like what 
you said, only abnormal terminations. In that case, let's keep it this way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to