Re: [PR] [FLINK-33988][configuration] Fix the invalid configuration when using initialized root logger level on yarn deployment mode [flink]

Tue, 16 Jan 2024 00:14:12 -0800 


RocMarshal commented on code in PR #24042:
URL: https://github.com/apache/flink/pull/24042#discussion_r1453061679


##########
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java:
##########
@@ -216,6 +229,24 @@ public YarnClusterDescriptor(
         this.nodeLabel = 
flinkConfiguration.getString(YarnConfigOptions.NODE_LABEL);
     }
 
+    /** Adapt flink env setting. */
+    private static <T> void adaptEnvSetting(
+            Configuration config,
+            ConfigOption<T> configOption,
+            String envKey,
+            Function<T, Boolean> validator) {

Review Comment:
   Hi, @1996fanrui Thanks for your quick-review~
   > Is my understanding right?
   
   Yes.
   
   I have to admit that I didn't consider compatibility with on k8s from the 
beginning.
   This is a trade-off between robustness and redundancy check for me.
   To be honest, I would prefer to remove this validation here. 😭 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to