1996fanrui commented on code in PR #24042:
URL: https://github.com/apache/flink/pull/24042#discussion_r1453078677
##########
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java:
##########
@@ -216,6 +229,24 @@ public YarnClusterDescriptor(
this.nodeLabel =
flinkConfiguration.getString(YarnConfigOptions.NODE_LABEL);
}
+ /** Adapt flink env setting. */
+ private static <T> void adaptEnvSetting(
+ Configuration config,
+ ConfigOption<T> configOption,
+ String envKey,
+ Function<T, Boolean> validator) {
Review Comment:
Removing is fine for me, the code will get clearer here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
